[BE] 7.03 매수 API 구현 #49 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
uuuo3o
approved these changes
Nov 11, 2024
| @@ -13,6 +13,7 @@ export function setupSwagger(app: INestApplication): void { | |||
| .setTitle('Juga API') | |||
| .setDescription('Juga API 문서입니다.') | |||
| .setVersion('1.0.0') | |||
| .addBearerAuth() | |||
There was a problem hiding this comment.
🟢 처음으로 토큰이 필요한 무언가가 나왔네요.. 고생하셨습니다!!
| created_at: Date; | ||
|
|
||
| @Column({ nullable: true }) | ||
| completed_at?: Date; |
There was a problem hiding this comment.
🟢 타입스크립트에서는 nullable한 값은 옵셔널로 두는게 관례인가요? 신기하네요
jinddings
approved these changes
Nov 11, 2024
| import { Injectable } from '@nestjs/common'; | ||
|
|
||
| @Injectable() | ||
| export class JwtAuthGuard extends AuthGuard('jwt') {} |
There was a problem hiding this comment.
🟢 오우 JwtAuthGuard를 클래스로 만들어서 사용할 수 있었네요 ..? 저는 AuthGuard('strategy 이름') 이런 식으로 사용해봤는데 가독성이나 이후 검증 로직을 추가하거나 하는데 좋을것 같네요 canActivate 함수에 원하는 로직을 넣거나 해서요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 주요 작업
💭 고민과 해결과정
@UseGuards데코레이터를 이용해서 user 정보를 가져올 수 있었다. request.user.id로 사용자의 아이디를 조회하도록 구현했다.